(adsbygoogle = window.adsbygoogle || []).push({}); Hello guys, can you please give me some feedback on my app? It's a simple command prompt based thing that will calculate how much more money you need to buy something. Here it is:

    #include "stdafx.h"



#include <iostream>





int subtract(int x, int y)

{

	return x - y;

}





int main()

{

	using namespace std;

	cout << "How much money does the desired item cost?";

	int x;

	cin >> x;

	cout << "How much money do you have currently?";

	int y;

	cin >> y;

	cout << "You need this much more: " << subtract(x, y) << endl;

	return 0;

}

Note: This was done in Visual C++ 2010 Express.

How could I improve it? How could I code it to ask how many items are wanted, and make it calculate how much more is needed to purchase the 2-3 items.

Thanks!

C++ If statement compiled assembly decompiled:

    int main() 

{ 

    int x = 0; 

    if (x == 0) 

    { 

        x = 1; 

    } 

    else 

    { 

        x = 2; 

    } 

    return 0; 

}  

You must login or register to view this content.

C++ Ternary operation compiled assembly decompiled:

    int main() 

{ 

    int x = 0; 

    x = x == 0 ? 1 : 2; 

    return 0; 

} 

You must login or register to view this content.

The if statement branches, the ternary does not. Therefore no memory leak possible unless your doing some other branching. But ternary is safer, and more efficient, and faster.

Ok, that is very cool, and i kind of understand that, but what does it have to do with how long a variable name is *Scratches head*

It doesn't lol, I was just showing how mine was teh best

Yea i know that, i use them for functions

#define isFive(x) (x == 5) ? 1 : 0

better than using an entire function for it.

    #define isEven(num) (num % 2 ==  0) ? true : false

I like your programming style, you should work with me some time.

In response to the first post, i came up with this:

    

#import <iostream>

using namespace std;



int main() {

	int items = 0;

	int i;

	float cost;

	float currentMoney;

	float total;

	cout << "How many items? ";

	cin >> items;

	cout << "How much money do you have? ";

	cin >> currentMoney;

	

	for(i = 0; i < items; i++) {

		cout << "Enter cost of item: ";

		cin >> cost[i];

		total += cost[i];

	}

	if(total <= currentMoney) {

		cout << "You have enough money.\n";

		cout << "Total Cost: " << total << endl;

	}

	 else if(total > currentMoney) {

	 cout << "You do not have enough money. You need " << total - currentMoney << " more.\n";

	 cout << "Total Cost: " << total << endl;

	 }

}

Your array is unnecessary, you never use it... Fixed your version.

Oops, i left that in there on accident .

Your welcome (Too short)